linux-kernel - Re: [PATCH 24/32] tools include: Add a _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1486695726.2192.1.camel@perches.com>
Date:   Thu, 09 Feb 2017 19:02:06 -0800
From:   Joe Perches <joe@...ches.com>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Ingo Molnar <mingo@...nel.org>
Cc:     linux-kernel@...r.kernel.org,
        Arnaldo Carvalho de Melo <acme@...hat.com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        David Ahern <dsahern@...il.com>, Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Wang Nan <wangnan0@...wei.com>,
        William Cohen <wcohen@...hat.com>
Subject: Re: [PATCH 24/32] tools include: Add a __fallthrough statement

On Thu, 2017-02-09 at 22:39 -0300, Arnaldo Carvalho de Melo wrote:
> From: Arnaldo Carvalho de Melo <acme@...hat.com>
> 
> For cases where implicit fall through case labels are intended,
> to let us inform that to gcc >= 7:

I believe this should be added to compiler_gcc.h

> diff --git a/tools/include/linux/compiler.h b/tools/include/linux/compiler.h
[]
> @@ -126,4 +126,13 @@ static __always_inline void __write_once_size(volatile void *p, void *res, int s
>  #define WRITE_ONCE(x, val) \
>  	({ union { typeof(x) __val; char __c[1]; } __u = { .__val = (val) }; __write_once_size(&(x), __u.__c, sizeof(x)); __u.__val; })
>  
> +
> +#ifndef __fallthrough
> +# if defined(__GNUC__) && __GNUC__ >= 7
> +#  define __fallthrough __attribute__ ((fallthrough))
> +# else
> +#  define __fallthrough
> +# endif
> +#endif
> +
>  #endif /* _TOOLS_LINUX_COMPILER_H */