linux-kernel - Re: [PATCH] HID: intel-ish-hid: constify device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1486805999.2528.1.camel@linux.intel.com>
Date:   Sat, 11 Feb 2017 01:39:59 -0800
From:   Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
To:     Bhumika Goyal <bhumirks@...il.com>, julia.lawall@...6.fr,
        jikos@...nel.org, benjamin.tissoires@...hat.com,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: intel-ish-hid: constify device_type structure

On Sat, 2017-02-11 at 12:40 +0530, Bhumika Goyal wrote:
> Declare device_type structure as const as it is only stored in the
> type field of a device structure. This field is of type const, so add
> const to the declaration of device_type structure.
> 
> File size before: drivers/hid/intel-ish-hid/ishtp/bus.o
>    text	   data	    bss	    dec	    hex	
> filename
>    4260	    336	     16	   4612	   1204
> hid/intel-ish-hid/ishtp/bus.o
> 
> File size after: drivers/hid/intel-ish-hid/ishtp/bus.o
>    text	   data	    bss	    dec	    hex	
> filename
>    4324	    272	     16	   4612	   1204
> hid/intel-ish-hid/ishtp/bus.o
> 
> Signed-off-by: Bhumika Goyal <bhumirks@...il.com>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>

> ---
>  drivers/hid/intel-ish-hid/ishtp/bus.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/intel-ish-hid/ishtp/bus.c
> b/drivers/hid/intel-ish-hid/ishtp/bus.c
> index f4cbc74..5f382fe 100644
> --- a/drivers/hid/intel-ish-hid/ishtp/bus.c
> +++ b/drivers/hid/intel-ish-hid/ishtp/bus.c
> @@ -358,7 +358,7 @@ static void ishtp_cl_dev_release(struct device
> *dev)
>  	kfree(to_ishtp_cl_device(dev));
>  }
>  
> -static struct device_type ishtp_cl_device_type = {
> +static const struct device_type ishtp_cl_device_type = {
>  	.release	= ishtp_cl_dev_release,
>  };
>