linux-kernel - Re: [PATCH 1/7] staging: iio: isl29028: change mdelay() to msleep()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 11 Feb 2017 09:41:39 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Brian Masney <masneyb@...tation.org>
Cc:     gregkh@...uxfoundation.org, linux-iio@...r.kernel.org,
        devel@...verdev.osuosl.org, knaack.h@....de, lars@...afoo.de,
        pmeerw@...erw.net, linux-kernel@...r.kernel.org,
        ldewangan@...dia.com
Subject: Re: [PATCH 1/7] staging: iio: isl29028: change mdelay() to msleep()

On 09/02/17 01:54, Brian Masney wrote:
> This driver in some cases can busy wait for upwards of 100 ms. Since the
> kernel at this point is not running in atomic context, and is running in
> process context, we can safely use msleep() instead. This patch changes
> the two occurrences of mdelay() to msleep().
> 
> Signed-off-by: Brian Masney <masneyb@...tation.org>
Applied to the togreg branch of iio.git and pushed out as testing for the
autobuilders to play with it.

Thanks,

Jonathan
> ---
>  drivers/staging/iio/light/isl29028.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/iio/light/isl29028.c b/drivers/staging/iio/light/isl29028.c
> index 6bb6d37..8dc24c94 100644
> --- a/drivers/staging/iio/light/isl29028.c
> +++ b/drivers/staging/iio/light/isl29028.c
> @@ -121,7 +121,7 @@ static int isl29028_enable_proximity(struct isl29028_chip *chip)
>  		return ret;
>  
>  	/* Wait for conversion to be complete for first sample */
> -	mdelay(DIV_ROUND_UP(1000, chip->prox_sampling));
> +	msleep(DIV_ROUND_UP(1000, chip->prox_sampling));
>  
>  	return 0;
>  }
> @@ -192,7 +192,7 @@ static int isl29028_set_als_ir_mode(struct isl29028_chip *chip,
>  		return ret;
>  
>  	/* Need to wait for conversion time if ALS/IR mode enabled */
> -	mdelay(ISL29028_CONV_TIME_MS);
> +	msleep(ISL29028_CONV_TIME_MS);
>  
>  	chip->als_ir_mode = mode;
>  
>