linux-kernel - Re: [PATCH] iio: 104-quad-8: Fix off-by-one error when addressing flag register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d89a328a-4873-021e-a92b-f0498cb49d03@kernel.org>
Date:   Sat, 11 Feb 2017 09:37:35 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     William Breathitt Gray <vilhelm.gray@...il.com>,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>
Cc:     linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: 104-quad-8: Fix off-by-one error when addressing
 flag register

On 09/02/17 15:03, William Breathitt Gray wrote:
> The flag register is offset by 1 from the respective channel data
> register. This patch fixes an off-by-one error when attempting to read a
> channel flag register where the base address was not properly offset.
> 
> Fixes: 28e5d3bb0325 ("iio: 104-quad-8: Add IIO support for the ACCES 104-QUAD-8")
> Signed-off-by: William Breathitt Gray <vilhelm.gray@...il.com>
Applied to the fixes-togreg-post-rc1 branch of iio.git
Clue to when this will go upstream is in the name ;)

Thanks,

Jonathan
> ---
>  drivers/iio/counter/104-quad-8.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/counter/104-quad-8.c b/drivers/iio/counter/104-quad-8.c
> index a5913e97945e..f9b8fc9ae13f 100644
> --- a/drivers/iio/counter/104-quad-8.c
> +++ b/drivers/iio/counter/104-quad-8.c
> @@ -76,7 +76,7 @@ static int quad8_read_raw(struct iio_dev *indio_dev,
>  			return IIO_VAL_INT;
>  		}
>  
> -		flags = inb(base_offset);
> +		flags = inb(base_offset + 1);
>  		borrow = flags & BIT(0);
>  		carry = !!(flags & BIT(1));
>  
>