linux-kernel - Re: [PATCH] hwrng: cavium: Use per device name to allow for multiple devices.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170211105646.GK855@gondor.apana.org.au>
Date:   Sat, 11 Feb 2017 18:56:46 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     David Daney <david.daney@...ium.com>
Cc:     linux-crypto@...r.kernel.org, Matt Mackall <mpm@...enic.com>,
        linux-kernel@...r.kernel.org,
        Omer Khaliq <okhaliq@...iumnetworks.com>,
        Ananth Jasty <Ananth.Jasty@...ium.com>
Subject: Re: [PATCH] hwrng: cavium: Use per device name to allow for multiple
 devices.

On Mon, Feb 06, 2017 at 02:28:46PM -0800, David Daney wrote:
> Systems containing the Cavium HW RNG may have one device per NUMA
> node.  A typical configuration is a 2-node NUMA system, which results
> in 2 RNG devices.  The hwrng subsystem refuses (and rightly so) to
> register more than one device with he same name, so we get failure
> messages on these systems.
> 
> Make the hwrng name unique by including the underlying device name.
> Also remove spaces from the name to make it possible to switch devices
> via the sysfs knobs.
> 
> Signed-off-by: David Daney <david.daney@...ium.com>

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt