linux-kernel - Re: [PATCH] Staging: arch/x86/kernel/setup.c : fixed empty line style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 11 Feb 2017 20:53:04 +0100 (CET)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Kishore Karanala <kishore.karanala@...il.com>
cc:     glx@...utronix.de, mingo@...hat.com, hpa@...or.com, x86@...nel.org,
        linux-kernel@...r.kernel.org, matt@...eblueprint.co.uk,
        rafael.j.wysocki@...el.com, thgarnie@...gle.com,
        arbab@...ux.vnet.ibm.com, dave.hansen@...ux.intel.com
Subject: Re: [PATCH] Staging: arch/x86/kernel/setup.c : fixed empty line
 style issue

On Sat, 11 Feb 2017, Kishore Karanala wrote:

> From: Kishore <kishore.karanala@...il.com>
> 
> Fixed empty line style issue

What? There is no issue. These empty lines are entirely correct and
removing them is just hurting readability.

Thanks,

	tglx

> Signed-off-by: Kishore Karanala <kishore.karanala@...il.com>
> ---
>  arch/x86/kernel/setup.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
> index 4cfba94..6d35649 100644
> --- a/arch/x86/kernel/setup.c
> +++ b/arch/x86/kernel/setup.c
> @@ -723,7 +723,6 @@ static void __init trim_snb_memory(void)
>  	 * already been reserved.
>  	 */
>  	memblock_reserve(0, 1<<20);
> -	
>  	for (i = 0; i < ARRAY_SIZE(bad_pages); i++) {
>  		if (memblock_reserve(bad_pages[i], PAGE_SIZE))
>  			printk(KERN_WARNING "failed to reserve 0x%08lx\n",
> @@ -815,7 +814,6 @@ static void __init trim_low_memory_range(void)
>  {
>  	memblock_reserve(0, ALIGN(reserve_low, PAGE_SIZE));
>  }
> -	
>  /*
>   * Dump out kernel offset information on panic.
>   */
> -- 
> 2.7.4
> 
>