linux-kernel - Re: [PATCH] MIPS: sync-r4k: Fix KERN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170211221918.GH24226@jhogan-linux.le.imgtec.org>
Date:   Sat, 11 Feb 2017 22:19:18 +0000
From:   James Hogan <james.hogan@...tec.com>
To:     Matt Redfearn <matt.redfearn@...tec.com>
CC:     Ralf Baechle <ralf@...ux-mips.org>, <linux-mips@...ux-mips.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] MIPS: sync-r4k: Fix KERN_CONT fallout

On Thu, Feb 02, 2017 at 01:22:04PM +0000, Matt Redfearn wrote:
> Since commit 4bcc595ccd80 ("printk: reinstate KERN_CONT for printing
> continuation lines") the output of counter synchornisation has been
> split across lines:
> [ 0.665181] Synchronize counters for CPU 1:
> [ 0.678578] done.
> 
> Fix this by using pr_cont, and replace printk with pr_info.
> 
> Signed-off-by: Matt Redfearn <matt.redfearn@...tec.com>

Applied

Thanks
James

> ---
> 
>  arch/mips/kernel/sync-r4k.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/mips/kernel/sync-r4k.c b/arch/mips/kernel/sync-r4k.c
> index 4472a7f98577..1df1160b6a47 100644
> --- a/arch/mips/kernel/sync-r4k.c
> +++ b/arch/mips/kernel/sync-r4k.c
> @@ -29,7 +29,7 @@ void synchronise_count_master(int cpu)
>  	int i;
>  	unsigned long flags;
>  
> -	printk(KERN_INFO "Synchronize counters for CPU %u: ", cpu);
> +	pr_info("Synchronize counters for CPU %u: ", cpu);
>  
>  	local_irq_save(flags);
>  
> @@ -83,7 +83,7 @@ void synchronise_count_master(int cpu)
>  	 * count registers were almost certainly out of sync
>  	 * so no point in alarming people
>  	 */
> -	printk("done.\n");
> +	pr_cont("done.\n");
>  }
>  
>  void synchronise_count_slave(int cpu)
> -- 
> 2.7.4
> 
> 

Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)