linux-kernel - Re: [PATCH] net: ethernet: ti: netcp_core: return netdev_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170211010839.GA4729@khorivan>
Date:   Sat, 11 Feb 2017 03:08:41 +0200
From:   Ivan Khoronzhuk <ivan.khoronzhuk@...aro.org>
To:     David Miller <davem@...emloft.net>
Cc:     w-kwok2@...com, m-karicheri2@...com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: ethernet: ti: netcp_core: return netdev_tx_t in xmit

On Fri, Feb 10, 2017 at 02:45:21PM -0500, David Miller wrote:
> From: Ivan Khoronzhuk <ivan.khoronzhuk@...aro.org>
> Date: Thu,  9 Feb 2017 16:24:14 +0200
> 
> > @@ -1300,7 +1301,7 @@ static int netcp_ndo_start_xmit(struct sk_buff *skb, struct net_device *ndev)
> >  			dev_warn(netcp->ndev_dev, "padding failed (%d), packet dropped\n",
> >  				 ret);
> >  			tx_stats->tx_dropped++;
> > -			return ret;
> > +			return NETDEV_TX_BUSY;
> >  		}
> >  		skb->len = NETCP_MIN_PACKET_SIZE;
> >  	}
> > @@ -1329,7 +1330,7 @@ static int netcp_ndo_start_xmit(struct sk_buff *skb, struct net_device *ndev)
> >  	if (desc)
> >  		netcp_free_tx_desc_chain(netcp, desc, sizeof(*desc));
> >  	dev_kfree_skb(skb);
> > -	return ret;
> > +	return NETDEV_TX_BUSY;
> >  }
> 
> I really think these should be returning NET_XMIT_DROP.

Yes, it seems here can be a little more changes then, will send new version
later.