linux-kernel - Re: Mistake in include IS_ENABLED(CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LSU.2.20.1702110852560.24579@cbobk.fhfr.pm>
Date:   Sat, 11 Feb 2017 08:54:59 +0100 (CET)
From:   Jiri Kosina <jikos@...nel.org>
To:     Denys Fedoryshchenko <nuclearcat@...learcat.com>
cc:     live-patching@...r.kernel.org, linux-kernel@...r.kernel.org,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        Jessica Yu <jeyu@...hat.com>, Miroslav Benes <mbenes@...e.cz>
Subject: Re: Mistake in include IS_ENABLED(CONFIG_LIVEPATCH)

On Sat, 11 Feb 2017, Denys Fedoryshchenko wrote:

> I noticed that sample of livepatch is not working in 4.9.9, because in
> include,
> linux/livepatch.h
> it is:
> #if IS_ENABLED(CONFIG_LIVEPATCH)
> 
> while config option is:
> CONFIG_HAVE_LIVEPATCH=y
> 
> After editing livepatch.h sample module compiles fine
> 
> Probably that's just a typo?

There are two config variables. CONFIG_HAVE_LIVEPATCH is set by those 
architectures for which livepatching implementation exists.

CONFIG_LIVEPATCH is the actual config option turning the support in kernel 
on/off.

What you are seeing is that if you have kernel configuration that has 
livepatching (CONFIG_LIVEPATCH) turned off, the sample module doesn't 
compile for it either. I'd say it's not unexpected behavior.

-- 
Jiri Kosina
SUSE Labs