lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sun, 12 Feb 2017 23:51:47 +0530
From:   Bhumika Goyal <>
To:     Thomas Gleixner <>
Cc:     Julia Lawall <>,,
        Mark Rutland <>,
        Marc Zyngier <>,
        Daniel Lezcano <>,,
        Kees Cook <>
Subject: Re: [PATCH] clocksource: add __ro_after_init to cyclecounter

On Sun, Feb 12, 2017 at 2:05 AM, Thomas Gleixner <> wrote:
> On Sun, 12 Feb 2017, Bhumika Goyal wrote:
> Please be more careful with your subject line. The prefix for this is
> definitely not 'clocksource'. git log would have told you the proper one:
> clocksource/drivers/arm_arch_timer
> 'clocksource' is the general subsystem and used for system wide changes or
> core changes, but not for a particular driver.

I will be more careful about this in future.


>> The object cyclecounter of type cyclecounter is not getting modified
>> after getting initialized by arch_counter_register. Apart from
>> initialization in arch_counter_register it is also passed as an argument
>> to the function timecounter_init but this argument is of type const.
>> Therefore, add __ro_after_init to its declaration.
> Other than that this is fine. I'll fix it up when applying.
> Thanks,
>         tglx

Powered by blists - more mailing lists