linux-kernel - drivers/staging/rtl8192u

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <b987a9bf-87e7-38ef-d52e-d6d416ab7795@canonical.com>
Date:   Sun, 12 Feb 2017 19:40:01 +0000
From:   Colin Ian King <colin.king@...onical.com>
To:     Jerry Chuang <jerry-chuang@...ltek.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "David S. Miller" <davem@...emloft.net>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: drivers/staging/rtl8192u

Hi,

Static analysis via CoverityScan picked up an issue in
cmpk_handle_query_config_rx where the following operation on an u8 is
clearly not correct:

	rx_query_cfg.cfg_action         = (pmsg[4] & 0x80000000) >> 31;

The result of this operation is always zero. I suspect this should be:

	x_query_cfg.cfg_action         = (pmsg[4] & 0x80) >> 7;

..but without a datasheet I cannot check if this assumption is correct
or not. Anyhow, it is clearly a bug that needs attention.

Colin