linux-kernel - Re: [PATCH] rbd: constify device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 13 Feb 2017 10:12:35 +0100
From:   Ilya Dryomov <idryomov@...il.com>
To:     Bhumika Goyal <bhumirks@...il.com>
Cc:     Julia Lawall <julia.lawall@...6.fr>, Sage Weil <sage@...hat.com>,
        Alex Elder <elder@...nel.org>,
        Ceph Development <ceph-devel@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] rbd: constify device_type structure

On Sat, Feb 11, 2017 at 7:44 AM, Bhumika Goyal <bhumirks@...il.com> wrote:
> Declare device_type structure as const as it is only stored in the
> type field of a device structure. This field is of type const, so add
> const to the declaration of device_type structure.
>
> File size before:
>    text    data     bss     dec     hex filename
>   61546   11610     208   73364   11e94 drivers/block/rbd.o
>
> File size after:
>    text    data     bss     dec     hex filename
>   61610   11578     208   73396   11eb4 drivers/block/rbd.o
>
> Signed-off-by: Bhumika Goyal <bhumirks@...il.com>
> ---
>  drivers/block/rbd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
> index 36d2b9f..dfc708b 100644
> --- a/drivers/block/rbd.c
> +++ b/drivers/block/rbd.c
> @@ -4779,7 +4779,7 @@ static ssize_t rbd_image_refresh(struct device *dev,
>
>  static void rbd_dev_release(struct device *dev);
>
> -static struct device_type rbd_device_type = {
> +static const struct device_type rbd_device_type = {
>         .name           = "rbd",
>         .groups         = rbd_attr_groups,
>         .release        = rbd_dev_release,

Applied.

Thanks,

                Ilya