lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 13 Feb 2017 10:59:50 +0900 From: Hoegeun Kwon <hoegeun.kwon@...sung.com> To: Rob Herring <robh@...nel.org>, David Airlie <airlied@...ux.ie>, Daniel Vetter <daniel.vetter@...el.com>, Sean Paul <seanpaul@...omium.org> Cc: Neil Armstrong <narmstrong@...libre.com>, Liviu Dudau <liviu.dudau@....com>, dri-devel@...ts.freedesktop.org, Tomi Valkeinen <tomi.valkeinen@...com>, Frank Rowand <frowand.list@...il.com>, Marek Vasut <marex@...x.de>, Kevin Hilman <khilman@...libre.com>, Chen-Yu Tsai <wens@...e.org>, Krzysztof Kozlowski <krzk@...nel.org>, Xinliang Liu <z.liuxinliang@...ilicon.com>, Javier Martinez Canillas <javier@....samsung.com>, Xinwei Kong <kong.kongxinwei@...ilicon.com>, Kukjin Kim <kgene@...nel.org>, Mali DP Maintainers <malidp@...s.arm.com>, devicetree@...r.kernel.org, Chen Feng <puck.chen@...ilicon.com>, Jyri Sarha <jsarha@...com>, Carlo Caione <carlo@...one.org>, Russell King <rmk+kernel@...linux.org.uk>, Matthias Brugger <matthias.bgg@...il.com>, Alison Wang <alison.wang@...escale.com>, Jingoo Han <jingoohan1@...il.com>, Seung-Woo Kim <sw0312.kim@...sung.com>, linux-kernel@...r.kernel.org, Kyungmin Park <kyungmin.park@...sung.com>, Rongrong Zou <zourongrong@...il.com>, Maxime Ripard <maxime.ripard@...e-electrons.com> Subject: Re: [PATCH v2 4/6] drm: convert drivers to use of_graph_get_remote_node > diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c > index a0def0be6d65..93ebb12133e1 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_mic.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c > @@ -228,29 +228,6 @@ static void mic_set_reg_on(struct exynos_mic *mic, bool enable) > writel(reg, mic->reg + MIC_OP); > } > > -static struct device_node *get_remote_node(struct device_node *from, int reg) > -{ > - struct device_node *endpoint = NULL, *remote_node = NULL; > - > - endpoint = of_graph_get_endpoint_by_regs(from, reg, -1); > - if (!endpoint) { > - DRM_ERROR("mic: Failed to find remote port from %s", > - from->full_name); > - goto exit; > - } > - > - remote_node = of_graph_get_remote_port_parent(endpoint); > - if (!remote_node) { > - DRM_ERROR("mic: Failed to find remote port parent from %s", > - from->full_name); > - goto exit; > - } > - > -exit: > - of_node_put(endpoint); > - return remote_node; > -} > - > static int parse_dt(struct exynos_mic *mic) > { > int ret = 0, i, j; > @@ -262,7 +239,7 @@ static int parse_dt(struct exynos_mic *mic) > * The first node must be for decon and the second one must be for dsi. > */ > for (i = 0, j = 0; i < NUM_ENDPOINTS; i++) { > - remote_node = get_remote_node(mic->dev->of_node, i); > + remote_node = of_graph_get_remote_node(mic->dev->of_node, i, 0); > if (!remote_node) { > ret = -EPIPE; > goto exit; > @@ -279,7 +256,7 @@ static int parse_dt(struct exynos_mic *mic) > break; > case ENDPOINT_DSI_NODE: Dear Rob, I have tested this patch, rebase these patches on samsung soc tree[1] and drm exynos tree[2]. But 4/6 patch can not be applied. Because there is a conflict with the already merged [3] patch. Best Regards, Hoegeun [1] https://git.kernel.org/cgit/linux/kernel/git/krzk/linux.git/ (for-next branch) [2] https://git.kernel.org/cgit/linux/kernel/git/daeinki/drm-exynos.git/ (exynos_drm_next branch) [3] drm/exynos: mic: Fix parse_dt function (cc2b0225) > /* panel node */ > - remote_node = get_remote_node(remote_node, 1); > + remote_node = of_graph_get_remote_node(remote_node, 1, 0); > if (!remote_node) { > ret = -EPIPE; > goto exit; > diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c > index ebd5f4fe4c23..18d6570e057d 100644 > --- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c > +++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c > @@ -247,34 +247,6 @@ static const struct component_master_ops kirin_drm_ops = { > .unbind = kirin_drm_unbind, > }; > >
Powered by blists - more mailing lists