linux-kernel - Re: [PATCH] sched/isolcpus: Show isolated cpu map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170213120650.GN6515@twins.programming.kicks-ass.net>
Date:   Mon, 13 Feb 2017 13:06:50 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Kefeng Wang <wangkefeng.wang@...wei.com>
Cc:     Ingo Molnar <mingo@...nel.org>, linux-kernel@...r.kernel.org,
        guohanjun@...wei.com, Prarit Bhargava <prarit@...hat.com>
Subject: Re: [PATCH] sched/isolcpus: Show isolated cpu map

On Mon, Feb 13, 2017 at 05:43:59PM +0800, Kefeng Wang wrote:
> The commit a6e4491c682a ("sched/isolcpus: Output warning when the
> 'isolcpus=' kernel parameter is invalid") adds an error message
> when specified cpu bigger than nr_cpu_ids, but nr_cpumask_bits in
> cpulist_parse() could be nr_cpu_ids or NR_CPUS.
> 
> eg, NR_CPUS=64, nr_cpu_ids=8 in ARM64, cpulist_parse() won't return
> -ERANGE if isolcpus=1-10;
> 

But why does cpulist_parse() use nr_cpumask_bits, that seems to be the
problem, so why not look there?