linux-kernel - Re: [PATCH v27 02/21] vfs: Add MAY_CREATE_FILE and MAY_CREATE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 13 Feb 2017 16:34:53 +0100
From:   Andreas Gruenbacher <agruenba@...hat.com>
To:     Miklos Szeredi <miklos@...redi.hu>
Cc:     Alexander Viro <viro@...iv.linux.org.uk>,
        Christoph Hellwig <hch@...radead.org>,
        "Theodore Ts'o" <tytso@....edu>,
        Andreas Dilger <adilger.kernel@...ger.ca>,
        "J. Bruce Fields" <bfields@...ldses.org>,
        Jeff Layton <jlayton@...chiereds.net>,
        Trond Myklebust <trond.myklebust@...marydata.com>,
        Anna Schumaker <anna.schumaker@...app.com>,
        Dave Chinner <david@...morbit.com>,
        linux-ext4 <linux-ext4@...r.kernel.org>,
        XFS Developers <xfs@....sgi.com>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>,
        Linux NFS Mailing List <linux-nfs@...r.kernel.org>,
        linux-cifs@...r.kernel.org, Linux API <linux-api@...r.kernel.org>
Subject: Re: [PATCH v27 02/21] vfs: Add MAY_CREATE_FILE and MAY_CREATE_DIR
 permission flags

Miklos,

On Fri, Dec 2, 2016 at 10:22 AM, Miklos Szeredi <miklos@...redi.hu> wrote:
> On Tue, Oct 11, 2016 at 2:50 PM, Andreas Gruenbacher
> <agruenba@...hat.com> wrote:
>> Richacls distinguish between creating non-directories and directories. To
>> support that, add an isdir parameter to may_create(). When checking
>> inode_permission() for create permission, pass in an additional
>> MAY_CREATE_FILE or MAY_CREATE_DIR mask flag.
>>
>> Add may_replace() to allow checking for delete and create access when
>> replacing an existing file in vfs_rename().
>
> That works for plain rename, but not for RENAME_EXCHANGE: is_dir and
> new_is_dir may be different, which means we can be deleting a
> non-directory *and* creating a directory in one dir and vice versa in
> the other.

ok, I see now. Should be fixed in the latest posting from just now.

Thanks a lot,
Andreas