linux-kernel - Re: [PATCH 2/2] usb: gadget: udc: remove unnecessary variable and update function prototype

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <xa1ta89qdqh3.fsf@mina86.com>
Date:   Mon, 13 Feb 2017 17:07:20 +0100
From:   Michal Nazarewicz <mina86@...a86.com>
To:     "Gustavo A. R. Silva" <garsilva@...eddedor.com>, balbi@...nel.org,
        gregkh@...uxfoundation.org, bhelgaas@...gle.com,
        heikki.krogerus@...ux.intel.com
Cc:     linux-geode@...ts.infradead.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] usb: gadget: udc: remove unnecessary variable and update function prototype

On Mon, Feb 13 2017, Gustavo A. R. Silva wrote:
> Remove unnecessary variable and update function prototype.
>
> Reviewed-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>

Acked-by: Michal Nazarewicz <mina86@...a86.com>

> ---
>  drivers/usb/gadget/udc/amd5536udc.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/usb/gadget/udc/amd5536udc.c b/drivers/usb/gadget/udc/amd5536udc.c
> index ded97a3..3f64a06 100644
> --- a/drivers/usb/gadget/udc/amd5536udc.c
> +++ b/drivers/usb/gadget/udc/amd5536udc.c
> @@ -608,9 +608,8 @@ udc_alloc_request(struct usb_ep *usbep, gfp_t gfp)
>  }
>  
>  /* frees pci pool descriptors of a DMA chain */
> -static int udc_free_dma_chain(struct udc *dev, struct udc_request *req)
> +static void udc_free_dma_chain(struct udc *dev, struct udc_request *req)
>  {
> -	int ret_val = 0;
>  	struct udc_data_dma *td = req->td_data;
>  	unsigned int i;
>  
> @@ -629,8 +628,6 @@ static int udc_free_dma_chain(struct udc *dev, struct udc_request *req)
>  		td = NULL;
>  		addr = addr_aux;
>  	}
> -
> -	return ret_val;
>  }
>  
>  /* Frees request packet, called by gadget driver */
> -- 
> 2.5.0
>

-- 
Best regards
ミハウ “𝓶𝓲𝓷𝓪86” ナザレヴイツ
«If at first you don’t succeed, give up skydiving»