linux-kernel - Re: [PATCH v2] regulator: devres: introduce managed enable and disable operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170213180129.wutjitdr72klhxwu@sirena.org.uk>
Date:   Mon, 13 Feb 2017 18:01:29 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Guenter Roeck <linux@...ck-us.net>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] regulator: devres: introduce managed enable and
 disable operations

On Sun, Feb 12, 2017 at 06:32:49PM -0800, Dmitry Torokhov wrote:

> v2: restored lost regulator_disable() stub

> Mark, note that there is also patch introducing devm_clk_prepare() and
> devm_clk_prepare_enable() that Russell did not hate so I think it will
> get applied eventually. I believe lack of CLK methods was cited as a
> reason for not having managed enable for regulators.

No, that's never been an issue.  The concern is partly that nobody
bothered writing the patch but also that it gets messy over suspend and
resume since you end up with drivers either doing explicit releases of
managed resources (which is not normally a good pattern) or mixing
managed and unmanaged access to the same resource which is also fun.  

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)