linux-kernel - Re: [PATCH v3 1/3] xen/privcmd: return -ENOTTY for unimplemented IOCTLs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b0c8b4a4-c1ef-808a-0df4-564d4b40e051@oracle.com>
Date:   Mon, 13 Feb 2017 13:52:36 -0500
From:   Boris Ostrovsky <boris.ostrovsky@...cle.com>
To:     Paul Durrant <paul.durrant@...rix.com>,
        xen-devel@...ts.xenproject.org, linux-kernel@...r.kernel.org
Cc:     Juergen Gross <jgross@...e.com>
Subject: Re: [PATCH v3 1/3] xen/privcmd: return -ENOTTY for unimplemented
 IOCTLs



On 02/13/2017 12:03 PM, Paul Durrant wrote:
> The code sets the default return code to -ENOSYS but then overrides this
> to -EINVAL in the switch() statement's default case, which is clearly
> silly.
>
> This patch removes the override and sets the default return code to
> -ENOTTY, which is the conventional return for an unimplemented ioctl.
>
> Signed-off-by: Paul Durrant <paul.durrant@...rix.com>

Applied to for-linus-4.11.

-boris