linux-kernel - RE: [PATCH] scsi: aacraid: fix information leak on hbainfo.driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 13 Feb 2017 20:18:49 +0000
From:   Raghava Aditya Renukunta <RaghavaAditya.Renukunta@...rosemi.com>
To:     Colin King <colin.king@...onical.com>,
        dl-esc-Aacraid Linux Driver <aacraid@...rosemi.com>,
        "James E . J . Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>
CC:     "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] scsi: aacraid: fix information leak on
 hbainfo.driver_name

Hello Colin,


> -----Original Message-----
> From: Colin King [mailto:colin.king@...onical.com]
> Sent: Tuesday, February 7, 2017 5:55 AM
> To: dl-esc-Aacraid Linux Driver <aacraid@...rosemi.com>; James E . J .
> Bottomley <jejb@...ux.vnet.ibm.com>; Martin K . Petersen
> <martin.petersen@...cle.com>; linux-scsi@...r.kernel.org
> Cc: kernel-janitors@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [PATCH] scsi: aacraid: fix information leak on hbainfo.driver_name
> 
> EXTERNAL EMAIL
> 
> 
> From: Colin Ian King <colin.king@...onical.com>
> 
> The driver_name field is not initialized and hence information
> on the stack is being leaked to userspace on the copy_to_user.
> Fix this.

I am curious, do you mean that the user will be able to retrieve garbage stack  values from the variables that were not set (driver_name etc)? .
 If so how is it a security threat?

Regards,
Raghava Aditya

> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/scsi/aacraid/commctrl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/aacraid/commctrl.c b/drivers/scsi/aacraid/commctrl.c
> index 614842a..eb48d0a 100644
> --- a/drivers/scsi/aacraid/commctrl.c
> +++ b/drivers/scsi/aacraid/commctrl.c
> @@ -1015,7 +1015,7 @@ static int aac_get_pci_info(struct aac_dev* dev,
> void __user *arg)
> 
>  static int aac_get_hba_info(struct aac_dev *dev, void __user *arg)
>  {
> -       struct aac_hba_info hbainfo;
> +       struct aac_hba_info hbainfo = { 0 };
> 
>         hbainfo.adapter_number          = (u8) dev->id;
>         hbainfo.system_io_bus_number    = dev->pdev->bus->number;
> --
> 2.10.2