linux-kernel - Re: [PATCH 0/3] Add support for MyGica T230C DVB-T2 stick

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <addf6591-3028-2950-17cc-b96e2fc37601@iki.fi>
Date:   Mon, 13 Feb 2017 07:02:52 +0200
From:   Antti Palosaari <crope@....fi>
To:     Stefan Brüns <stefan.bruens@...h-aachen.de>,
        linux-media@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org,
        Mauro Carvalho Chehab <mchehab@...nel.org>
Subject: Re: [PATCH 0/3] Add support for MyGica T230C DVB-T2 stick

On 02/12/2017 05:26 PM, Stefan Brüns wrote:
> The required command sequence for the new tuner (Si2141) was traced from the
> current Windows driver and verified with a small python script/libusb.
> The changes to the Si2168 and cxusb driver are mostly addition of the
> required IDs and some glue code.
>
> Stefan Brüns (3):
>   [media] si2157: Add support for Si2141-A10
>   [media] si2168: add support for Si2168-D60
>   [media] cxusb: MyGica T230C support
>
>  drivers/media/dvb-core/dvb-usb-ids.h      |  1 +
>  drivers/media/dvb-frontends/si2168.c      |  4 ++
>  drivers/media/dvb-frontends/si2168_priv.h |  2 +
>  drivers/media/tuners/si2157.c             | 23 ++++++++-
>  drivers/media/tuners/si2157_priv.h        |  2 +
>  drivers/media/usb/dvb-usb/cxusb.c         | 80 +++++++++++++++++++++++++++++--
>  6 files changed, 106 insertions(+), 6 deletions(-)
>

Patch set looks pretty correct, but remote controller is something I 
hope you could fix. Old T230 did it wrong and defined 
rc_map_d680_dmb_table whilst proper map is 
RC_MAP_TOTAL_MEDIA_IN_HAND_02. Secondly it should be converted to 
rc-core. Even those are wrong for old revision, for new devices those 
should be done correct.

regards
Antti
-- 
http://palosaari.fi/