linux-kernel - Re: [PATCH] llist: Don't reinvent the wheel but use existing llist API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87lgtatztv.fsf@yhuang-dev.intel.com>
Date:   Mon, 13 Feb 2017 13:38:36 +0800
From:   "Huang\, Ying" <ying.huang@...el.com>
To:     Byungchul Park <byungchul.park@....com>
Cc:     <peterz@...radead.org>, <mingo@...nel.org>,
        <koverstreet@...gle.com>, <neilb@...e.de>, <nab@...ux-iscsi.org>,
        <viro@...iv.linux.org.uk>, <ying.huang@...el.com>,
        <oleg@...hat.com>, <asias@...hat.com>, <shli@...nel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] llist: Don't reinvent the wheel but use existing llist API

Hi, Byungchul,

Byungchul Park <byungchul.park@....com> writes:

> Although llist provides proper APIs, they are not used. Make them used.
>
> Signed-off-by: Byungchul Park <byungchul.park@....com>
> ---
>  drivers/md/bcache/closure.c | 15 ++-------------
>  drivers/md/raid5.c          |  4 +---
>  drivers/vhost/scsi.c        |  9 ++-------
>  fs/file_table.c             | 12 +++++-------
>  fs/namespace.c              | 12 +++++-------
>  include/linux/llist.h       |  3 +++
>  kernel/irq_work.c           |  6 +-----
>  kernel/sched/core.c         | 13 ++-----------
>  mm/vmalloc.c                |  8 +++-----

I think you need to split the patch.  One for each subsystem, this makes
it easier to be reviewed and merged.

Best Regards,
Huang, Ying

[snip]