linux-kernel - [tip:timers/core] math64, tile: Fix build failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 14 Feb 2017 00:43:02 -0800
From:   tip-bot for Sudip Mukherjee <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, sudip.mukherjee@...ethink.co.uk,
        sudipm.mukherjee@...il.com, cmetcalf@...lanox.com, hpa@...or.com,
        mingo@...nel.org, tglx@...utronix.de, peterz@...radead.org
Subject: [tip:timers/core] math64, tile: Fix build failure

Commit-ID:  dba9a0babdd938a51d11ae81f9c40d07ca613f43
Gitweb:     http://git.kernel.org/tip/dba9a0babdd938a51d11ae81f9c40d07ca613f43
Author:     Sudip Mukherjee <sudipm.mukherjee@...il.com>
AuthorDate: Tue, 24 Jan 2017 16:39:21 +0000
Committer:  Thomas Gleixner <tglx@...utronix.de>
CommitDate: Tue, 14 Feb 2017 09:39:13 +0100

math64, tile: Fix build failure

The build of tilegx allmodconfig fails with:
../arch/tile/include/asm/div64.h:5:15: error: unknown type name 'u64'
 static inline u64 mul_u32_u32(u32 a, u32 b)
               ^~~
../arch/tile/include/asm/div64.h:5:31: error: unknown type name 'u32'
 static inline u64 mul_u32_u32(u32 a, u32 b)
                               ^~~
../arch/tile/include/asm/div64.h:5:38: error: unknown type name 'u32'
 static inline u64 mul_u32_u32(u32 a, u32 b)
                                      ^~~
In file included from ../fs/ubifs/ubifs.h:26:0,
                 from ../fs/ubifs/shrinker.c:42:
../include/linux/math64.h: In function 'mul_u64_u32_shr':
../arch/tile/include/asm/div64.h:9:21: error: implicit declaration of
	function 'mul_u32_u32' [-Werror=implicit-function-declaration]

Include the linux/types.h in tiles div64.h to slve the problem.

Fixes: 9e3d6223d209 ("math64, timers: Fix 32bit mul_u64_u32_shr() and friends")
Signed-off-by: Sudip Mukherjee <sudip.mukherjee@...ethink.co.uk>
Acked-by: Chris Metcalf <cmetcalf@...lanox.com>
Cc: Peter Zijlstra <peterz@...radead.org>
Cc: Sudip Mukherjee <sudipm.mukherjee@...il.com>
Link: http://lkml.kernel.org/r/1485275961-20112-1-git-send-email-sudip.mukherjee@codethink.co.uk
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
---
 arch/tile/include/asm/div64.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/tile/include/asm/div64.h b/arch/tile/include/asm/div64.h
index bf61619..9f765cd 100644
--- a/arch/tile/include/asm/div64.h
+++ b/arch/tile/include/asm/div64.h
@@ -1,6 +1,8 @@
 #ifndef _ASM_TILE_DIV64_H
 #define _ASM_TILE_DIV64_H
 
+#include <linux/types.h>
+
 #ifdef __tilegx__
 static inline u64 mul_u32_u32(u32 a, u32 b)
 {