linux-kernel - Re: [PATCH v3 2/2] powerpc: emulate_step tests for load/store instructions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <877f4tm4n2.fsf@concordia.ellerman.id.au>
Date:   Tue, 14 Feb 2017 21:46:25 +1100
From:   Michael Ellerman <mpe@...erman.id.au>
To:     Ravi Bangoria <ravi.bangoria@...ux.vnet.ibm.com>,
        linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Cc:     benh@...nel.crashing.org, paulus@...ba.org,
        lsorense@...lub.uwaterloo.ca, oohall@...il.com,
        naveen.n.rao@...ux.vnet.ibm.com, ast@...nel.org,
        chris@...troguy.com, aneesh.kumar@...ux.vnet.ibm.com,
        bsingharora@...il.com, anton@...ba.org,
        paul.gortmaker@...driver.com, bauerman@...ux.vnet.ibm.com,
        viro@...iv.linux.org.uk, christophe.leroy@....fr, duwe@....de,
        oss@...error.net, Ravi Bangoria <ravi.bangoria@...ux.vnet.ibm.com>
Subject: Re: [PATCH v3 2/2] powerpc: emulate_step tests for load/store instructions

Ravi Bangoria <ravi.bangoria@...ux.vnet.ibm.com> writes:

> diff --git a/arch/powerpc/lib/Makefile b/arch/powerpc/lib/Makefile
> index 0e649d7..ddc879d 100644
> --- a/arch/powerpc/lib/Makefile
> +++ b/arch/powerpc/lib/Makefile
> @@ -33,3 +33,7 @@ obj-$(CONFIG_ALTIVEC)	+= xor_vmx.o
>  CFLAGS_xor_vmx.o += -maltivec $(call cc-option,-mabi=altivec)
>  
>  obj-$(CONFIG_PPC64) += $(obj64-y)
> +
> +ifeq ($(CONFIG_PPC64), y)
> +obj-$(CONFIG_KPROBES_SANITY_TEST) += test_emulate_step.o
> +endif

FYI, the right way to do that is:

  obj64-$(CONFIG_KPROBES_SANITY_TEST) += test_emulate_step.o
  obj-$(CONFIG_PPC64) += $(obj64-y)

And in this Makefile you don't need to add the second line because it's
already there.

cheers