linux-kernel - Re: [PATCH 3/3] perf: Allow kernel filters on cpu events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87fujhkjwm.fsf@ashishki-desk.ger.corp.intel.com>
Date:   Tue, 14 Feb 2017 14:59:37 +0200
From:   Alexander Shishkin <alexander.shishkin@...ux.intel.com>
To:     Ingo Molnar <mingo@...nel.org>
Cc:     Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
        vince@...ter.net, eranian@...gle.com,
        Arnaldo Carvalho de Melo <acme@...radead.org>,
        Will Deacon <will.deacon@....com>,
        Mark Rutland <mark.rutland@....com>,
        Mathieu Poirier <mathieu.poirier@...aro.org>
Subject: Re: [PATCH 3/3] perf: Allow kernel filters on cpu events

Ingo Molnar <mingo@...nel.org> writes:

> * Alexander Shishkin <alexander.shishkin@...ux.intel.com> wrote:
>
>> While supporting file-based address filters for cpu events requires some
>> extra context switch handling, kernel address filters are easy, since the
>> kernel mapping is preserved across address spaces. It is also useful as
>> it permits tracing scheduling paths of the kernel.
>> 
>> This patch allows setting up kernel filters for cpu events.
>> 
>> Signed-off-by: Alexander Shishkin <alexander.shishkin@...ux.intel.com>
>> Cc: Mathieu Poirier <mathieu.poirier@...aro.org>
>> ---
>>  include/linux/perf_event.h |  2 ++
>>  kernel/events/core.c       | 42 ++++++++++++++++++++++++++++--------------
>>  2 files changed, 30 insertions(+), 14 deletions(-)
>> 
>> diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
>> index fcb37c81ca..f4ea0600b2 100644
>> --- a/include/linux/perf_event.h
>> +++ b/include/linux/perf_event.h
>> @@ -486,6 +486,7 @@ struct perf_addr_filter {
>>   * @list:	list of filters for this event
>>   * @lock:	spinlock that serializes accesses to the @list and event's
>>   *		(and its children's) filter generations.
>> + * @nr_file_filters:	number of file-based filters
>
> I've applied the patch, but please for heaven's sake, when you add such a long, 
> long argument name, at minimum re-tabulate the documentation section to look good 
> again ...

Will do.

>From 8b993fa566acb0cd333ce5e433f1e6858b181f58 Mon Sep 17 00:00:00 2001
From: Alexander Shishkin <alexander.shishkin@...ux.intel.com>
Date: Tue, 14 Feb 2017 14:49:41 +0200
Subject: [PATCH] perf: Fix alignment in a kerneldoc comment

Commit 6ce77bfd6c ("perf/core: Allow kernel filters on CPU events") added
"nr_file_filters" to the filters structure and its kerneldoc description,
which now requires that other fields' descriptions be padded to the next
tabstop to not look ugly.

Signed-off-by: Alexander Shishkin <alexander.shishkin@...ux.intel.com>
---
 include/linux/perf_event.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
index 258ebdb533..8f347b84cf 100644
--- a/include/linux/perf_event.h
+++ b/include/linux/perf_event.h
@@ -503,9 +503,9 @@ struct perf_addr_filter {
 
 /**
  * struct perf_addr_filters_head - container for address range filters
- * @list:	list of filters for this event
- * @lock:	spinlock that serializes accesses to the @list and event's
- *		(and its children's) filter generations.
+ * @list:		list of filters for this event
+ * @lock:		spinlock that serializes accesses to the @list and
+ *			event's (and its children's) filter generations.
  * @nr_file_filters:	number of file-based filters
  *
  * A child event will use parent's @list (and therefore @lock), so they are
-- 
2.11.0