linux-kernel - Re: sched: check negative err value to safe one level of indent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170214152034.GB7671@nanopsycho>
Date:   Tue, 14 Feb 2017 16:20:34 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Colin Ian King <colin.king@...onical.com>
Cc:     Jiri Pirko <jiri@...lanox.com>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        "David S. Miller" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: sched: check negative err value to safe one level of indent

Tue, Feb 14, 2017 at 04:10:13PM CET, colin.king@...onical.com wrote:
>Jiro,
>
>A recent static analysis run with CoverityScan identified a potential
>change in functionality with your recent commit "sched: check negative
>err value to safe one level of indent" that landed in linux-next.
>
>The original path for case RTM_DELTFILTER would always goto errout, but
>your commit seems to goto errout only if err is non-zero zero and the
>err == 0 path falls through to the RTM_GETTFILTER case.  I'm not sure if
>this is an intentional change in behaviour.  From what I can make out,
>there is a missing goto errout before the fall-through to RTM_GETTFILTER.

Will fix. Thanks.


>
>Colin