linux-kernel - Re: [PATCH] usb: musb: add code comment for clarification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170214121202.Horde.qAfQoW59o5zs8CWtQR4bQyI@gator4166.hostgator.com>
Date:   Tue, 14 Feb 2017 12:12:02 -0600
From:   "Gustavo A. R. Silva" <garsilva@...eddedor.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Bin Liu <b-liu@...com>, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: musb: add code comment for clarification


Quoting Greg KH <gregkh@...uxfoundation.org>:

> On Fri, Feb 10, 2017 at 06:57:41PM -0600, Gustavo A. R. Silva wrote:
>> Add code comment to make it clear that the fall-through is intentional.
>> Read the link for more details: https://lkml.org/lkml/2017/2/9/292
>>
>> Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>
>> ---
>>  drivers/usb/musb/musb_core.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
>> index 892088f..1aec986 100644
>> --- a/drivers/usb/musb/musb_core.c
>> +++ b/drivers/usb/musb/musb_core.c
>> @@ -1869,6 +1869,7 @@ static void musb_pm_runtime_check_session(struct musb
>> *musb)
>>
>>                         return;
>>                 }
>> +               /* fall through */
>>         case MUSB_QUIRK_A_DISCONNECT_19:
>>                 if (musb->quirk_retries--) {
>>                         musb_dbg(musb,
>
> The tabs are all gone from this patch, and it's line-wrapped, making it
> impossible to be applied :(
>
> Can you please fix this and resend?
>

OK. I'll send it shortly.

Thanks
--
Gustavo A. R. Silva