linux-kernel - Re: [PATCH 1/5] selftests: Fix selftests build to just build, not run tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87shnhmsl1.fsf@concordia.ellerman.id.au>
Date:   Tue, 14 Feb 2017 13:09:14 +1100
From:   Michael Ellerman <mpe@...erman.id.au>
To:     shuahkh@....samsung.com, bamvor.zhangjian@...wei.com
Cc:     linuxppc-dev@...abs.org, linux-kernel@...r.kernel.org,
        linux-kselftest@...r.kernel.org, linux-api@...r.kernel.org
Subject: Re: [PATCH 1/5] selftests: Fix selftests build to just build, not run tests

Michael Ellerman <mpe@...erman.id.au> writes:

> In commit 88baa78d1f31 ("selftests: remove duplicated all and clean
> target"), the "all" target was removed from individual Makefiles and
> added to lib.mk.
>
> However the "all" target was added to lib.mk *after* the existing
> "runtests" target. This means "runtests" becomes the first (default)
> target for most of our Makefiles.
...
>
> Fix it by moving the "all" target to the start of lib.mk, making it the
> default target.
>
> Fixes: 88baa78d1f31 ("selftests: remove duplicated all and clean target")
> Signed-off-by: Michael Ellerman <mpe@...erman.id.au>

Hi Shuah,

Can you please merge this series into linux-next?

The selftests are badly broken otherwise.

cheers