linux-kernel - [PATCH v2 2/2] usb: gadget: udc: remove unnecessary variable and update function prototype

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170214220302.GA6218@embeddedgus>
Date:   Tue, 14 Feb 2017 16:03:02 -0600
From:   "Gustavo A. R. Silva" <garsilva@...eddedor.com>
To:     Michal Nazarewicz <mina86@...a86.com>
Cc:     balbi@...nel.org, gregkh@...uxfoundation.org, bhelgaas@...gle.com,
        heikki.krogerus@...ux.intel.com, linux-geode@...ts.infradead.org,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        "Gustavo A. R. Silva" <garsilva@...eddedor.com>
Subject: [PATCH v2 2/2] usb: gadget: udc: remove unnecessary variable and
 update function prototype

Remove unnecessary variable and update function prototype.

Acked-by: Michal Nazarewicz <mina86@...a86.com>
Reviewed-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>
---
Changes in v2:
 None.

 drivers/usb/gadget/udc/amd5536udc.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/usb/gadget/udc/amd5536udc.c b/drivers/usb/gadget/udc/amd5536udc.c
index 821d088..67dd209 100644
--- a/drivers/usb/gadget/udc/amd5536udc.c
+++ b/drivers/usb/gadget/udc/amd5536udc.c
@@ -608,9 +608,8 @@ udc_alloc_request(struct usb_ep *usbep, gfp_t gfp)
 }
 
 /* frees pci pool descriptors of a DMA chain */
-static int udc_free_dma_chain(struct udc *dev, struct udc_request *req)
+static void udc_free_dma_chain(struct udc *dev, struct udc_request *req)
 {
-	int ret_val = 0;
 	struct udc_data_dma *td = req->td_data;
 	unsigned int i;
 
@@ -626,8 +625,6 @@ static int udc_free_dma_chain(struct udc *dev, struct udc_request *req)
 		pci_pool_free(dev->data_requests, td, addr);
 		addr = addr_next;
 	}
-
-	return ret_val;
 }
 
 /* Frees request packet, called by gadget driver */
-- 
2.5.0