linux-kernel - Re: [PATCH] cdrom: Make device operations read-only

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170213.215811.902501442022534048.davem@davemloft.net>
Date:   Mon, 13 Feb 2017 21:58:11 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     keescook@...omium.org
Cc:     linux-kernel@...r.kernel.org, axboe@...nel.dk, corbet@....net,
        tim@...erelk.net, bp@...en8.de, jejb@...ux.vnet.ibm.com,
        martin.petersen@...cle.com, linux-doc@...r.kernel.org,
        linux-ide@...r.kernel.org, linux-scsi@...r.kernel.org,
        kernel-hardening@...ts.openwall.com
Subject: Re: [PATCH] cdrom: Make device operations read-only

From: Kees Cook <keescook@...omium.org>
Date: Mon, 13 Feb 2017 16:25:26 -0800

> diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c
> index 9cbd217bc0c9..ab9232e1e16f 100644
> --- a/drivers/ide/ide-cd.c
> +++ b/drivers/ide/ide-cd.c
> @@ -1166,7 +1166,7 @@ void ide_cdrom_update_speed(ide_drive_t *drive, u8 *buf)
>  	 CDC_CD_RW | CDC_DVD | CDC_DVD_R | CDC_DVD_RAM | CDC_GENERIC_PACKET | \
>  	 CDC_MO_DRIVE | CDC_MRW | CDC_MRW_W | CDC_RAM)
>  
> -static struct cdrom_device_ops ide_cdrom_dops = {
> +static const struct cdrom_device_ops ide_cdrom_dops = {
>  	.open			= ide_cdrom_open_real,
>  	.release		= ide_cdrom_release_real,
>  	.drive_status		= ide_cdrom_drive_status,

Acked-by: David S. Miller <davem@...emloft.net>