linux-kernel - Re: [PATCH 3/5] selftests: Fix the .S and .S -> .o rules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 14 Feb 2017 11:07:28 +0800
From:   Bamvor Zhang Jian <bamvor.zhangjian@...aro.org>
To:     Michael Ellerman <mpe@...erman.id.au>
Cc:     Shuah Khan <shuahkh@....samsung.com>,
        "Zhang Jian(Bamvor)" <bamvor.zhangjian@...wei.com>,
        lkml <linux-kernel@...r.kernel.org>, linuxppc-dev@...abs.org,
        linux-kselftest@...r.kernel.org,
        linux-api <linux-api@...r.kernel.org>
Subject: Re: [PATCH 3/5] selftests: Fix the .S and .S -> .o rules

Tested-by: Bamvor Jian Zhang <bamvor.zhangjian@...aro.org>

On 9 February 2017 at 16:56, Michael Ellerman <mpe@...erman.id.au> wrote:
> Both these rules incorrectly use $< (first prerequisite) rather than
> $^ (all prerequisites), meaning they don't work if we're using more than
> one .S file as input. Switch them to using $^.
>
> They also don't include $(CPPFLAGS) and other variables used in the
> default rules, which breaks targets that require those. Fix that by
> using the builtin $(COMPILE.S) and $(LINK.S) rules.
>
> Fixes: a8ba798bc8ec ("selftests: enable O and KBUILD_OUTPUT")
> Signed-off-by: Michael Ellerman <mpe@...erman.id.au>
> ---
>  tools/testing/selftests/lib.mk | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk
> index 98841c54763a..ce96d80ad64f 100644
> --- a/tools/testing/selftests/lib.mk
> +++ b/tools/testing/selftests/lib.mk
> @@ -54,9 +54,9 @@ $(OUTPUT)/%:%.c
>         $(LINK.c) $^ $(LDLIBS) -o $@
>
>  $(OUTPUT)/%.o:%.S
> -       $(CC) $(ASFLAGS) -c $< -o $@
> +       $(COMPILE.S) $^ -o $@
>
>  $(OUTPUT)/%:%.S
> -       $(CC) $(ASFLAGS) $< -o $@
> +       $(LINK.S) $^ $(LDLIBS) -o $@
>
>  .PHONY: run_tests all clean install emit_tests
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-api" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html