linux-kernel - Re: [PATCH] staging: rtl8192u: Fix warnings about endianness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201702151752.Q4Fn0kEO%fengguang.wu@intel.com>
Date:   Wed, 15 Feb 2017 17:44:51 +0800
From:   kbuild test robot <lkp@...el.com>
To:     maomao xu <albert008.xu@...il.com>
Cc:     kbuild-all@...org, gregkh@...uxfoundation.org, bhumirks@...il.com,
        singhalsimran0@...il.com, nikolas@....org, bhaktipriya96@...il.com,
        elise.lennion@...il.com, albert008.xu@...il.com,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8192u: Fix warnings about endianness

Hi maomao,

[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v4.10-rc8 next-20170215]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/maomao-xu/staging-rtl8192u-Fix-warnings-about-endianness/20170215-171426
config: x86_64-randconfig-x019-201707 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All error/warnings (new ones prefixed by >>):

   drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c: In function 'ieee80211_indicate_packets':
>> drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c:563:38: error: implicit declaration of function 'kb_push' [-Werror=implicit-function-declaration]
        put_unaligned_be16(sub_skb->len, kb_push(sub_skb, 2));
                                         ^~~~~~~
>> drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c:563:38: warning: passing argument 2 of 'put_unaligned_be16' makes pointer from integer without a cast [-Wint-conversion]
   In file included from arch/x86/include/asm/unaligned.h:8:0,
                    from include/linux/etherdevice.h:28,
                    from drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c:40:
   include/linux/unaligned/access_ok.h:52:29: note: expected 'void *' but argument is of type 'int'
    static __always_inline void put_unaligned_be16(u16 val, void *p)
                                ^~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/kb_push +563 drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c

   557				 * replace EtherType */
   558					skb_pull(sub_skb, SNAP_SIZE);
   559					memcpy(skb_push(sub_skb, ETH_ALEN), prxb->src, ETH_ALEN);
   560					memcpy(skb_push(sub_skb, ETH_ALEN), prxb->dst, ETH_ALEN);
   561				} else {
   562				/* Leave Ethernet header part of hdr and full payload */
 > 563					put_unaligned_be16(sub_skb->len, kb_push(sub_skb, 2));
   564					memcpy(skb_push(sub_skb, ETH_ALEN), prxb->src, ETH_ALEN);
   565					memcpy(skb_push(sub_skb, ETH_ALEN), prxb->dst, ETH_ALEN);
   566				}

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (24805 bytes)