linux-kernel - Re: [PATCH v9 0/8] perf/amd/iommu: Enable multi-IOMMU support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170215104424.GA8207@krava>
Date:   Wed, 15 Feb 2017 11:44:24 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     Borislav Petkov <bp@...en8.de>
Cc:     Suravee Suthikulpanit <Suravee.Suthikulpanit@....com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Jiri Olsa <jolsa@...nel.org>, Ingo Molnar <mingo@...nel.org>,
        linux-kernel@...r.kernel.org, iommu@...ts.linux-foundation.org,
        peterz@...radead.org, joro@...tes.org, mingo@...hat.com
Subject: Re: [PATCH v9 0/8] perf/amd/iommu: Enable multi-IOMMU support

On Wed, Feb 15, 2017 at 11:13:23AM +0100, Borislav Petkov wrote:
> On Tue, Feb 07, 2017 at 02:40:28AM -0600, Suravee Suthikulpanit wrote:
> > From: Suravee Suthikulpanit <suravee.suthikulpanit@....com>
> > 
> > This patch series modifies the existing IOMMU and Perf drivers to support
> > systems with multiple IOMMUs by allocating an amd_iommu PMU per IOMMU instance.
> > This allows users to specify performance events and filters separately for each
> > IOMMU.
> > 
> > This has been tested on the new family17h-based server w/ multiple IOMMUs.
> 
> Ok, so far so good.
> 
> There's just one thing:
> 
> $ perf stat -e amd_iommu_X/Y
> 
> says <not supported> and only doing the system wide tracing with -a does
> it count events.

does it say unsupported when you omit -a? it should display error
and options like:

[jolsa@...va perf]$ ./perf stat -e 'cpu/cpu-cycles/'

 Usage: perf stat [<options>] [<command>]

    -a, --all-cpus        system-wide collection from all CPUs
    -A, --no-aggr         disable CPU count aggregation
    -B, --big-num         print large numbers with thousands' separators
    -C, --cpu <cpu>       list of cpus to monitor in system-wide
...


> 
> So, lemme ask perf tool people, can we guys make the -a thing default
> when detect that we're running only uncore events which all should need
> -a anyway?

it's possible, can't think of anything being hurt by this now..

jirka