linux-kernel - Re: [PATCH] gpio: dwapb: Add support for next generation of X-Gene SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170215112001.GA30801@page>
Date:   Wed, 15 Feb 2017 11:20:01 +0000
From:   Jamie Iles <jamie@...ieiles.com>
To:     Hoan Tran <hotran@....com>
Cc:     Jamie Iles <jamie@...ieiles.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Weike Chen <alvin.chen@...el.com>,
        Alexandre Courbot <gnurou@...il.com>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Loc Ho <lho@....com>, Duc Dang <dhdang@....com>
Subject: Re: [PATCH] gpio: dwapb: Add support for next generation of X-Gene
 SoC

Hi Hoan,

On Tue, Feb 14, 2017 at 05:22:09PM -0800, Hoan Tran wrote:
> Hi Linus, Jamie and all,
> 
> Do you have any comments on this patch?

I think that the CONFIG_ACPI ifdef can be removed to clean it up - 
acpi_match_device() returns NULL for !CONFIG_ACPI.

Other than that, looks good to me.

Jamie