linux-kernel - Re: [PATCH] m32r: mm: fix build warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170215113822.GA10057@sudip-tp>
Date:   Wed, 15 Feb 2017 11:38:22 +0000
From:   Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] m32r: mm: fix build warning

On Tue, Feb 14, 2017 at 02:15:51PM -0800, Andrew Morton wrote:
> On Tue, 14 Feb 2017 22:05:45 +0000 Sudip Mukherjee <sudipm.mukherjee@...il.com> wrote:
> 
> > The build of m32r was giving warning:
> > mm/pgtable-generic.c: In function 'ptep_clear_flush':
> > mm/pgtable-generic.c:76:20: warning:
> > 	unused variable 'mm' [-Wunused-variable]
> > 
> > The implementation of ptep_get_and_clear() and pte_accessible()
> > does not use 'mm'.
> 
> That's because ptep_get_and_clear() and pte_accessible() are
> implemented as macros.  If they were (static inline) C functions then
> this warning wouldn't occur.  All the other architectures get this
> right.

oops.. sorry.. usually I will check all the other arch before sending a
patch but missed it this time.
Will investigate further today and send you a modified patch.

Regards
Sudip