linux-kernel - Re: [PATCH v2] tty: pl011: Work around QDF2400 E44 stuck BUSY bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170215122415.GG31733@leverpostej>
Date:   Wed, 15 Feb 2017 12:24:16 +0000
From:   Mark Rutland <mark.rutland@....com>
To:     Timur Tabi <timur@...eaurora.org>,
        Christopher Covington <cov@...eaurora.org>
CC:     Jonathan Corbet <corbet@....net>,
        Marc Zyngier <marc.zyngier@....com>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will.deacon@....com>, <linux-doc@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        Peter Hurley <peter@...leysoftware.com>,
        Aleksey Makarov <aleksey.makarov@...aro.org>,
        Robin Murphy <robin.murphy@....com>,
        <linux-kernel@...r.kernel.org>, <shankerd@...eaurora.org>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>,
        Russell King <linux@...linux.org.uk>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jslaby@...e.com>, <linux-acpi@...r.kernel.org>,
        <linux-serial@...r.kernel.org>,
        Mark Langsdorf <mlangsdo@...hat.com>,
        Mark Salter <msalter@...hat.com>, Jon Masters <jcm@...hat.com>,
        Neil Leeder <nleeder@...eaurora.org>, <nd@....com>
Subject: Re: [PATCH v2] tty: pl011: Work around QDF2400 E44 stuck BUSY bit

Hi,

On Tue, Feb 14, 2017 at 08:39:40PM -0600, Timur Tabi wrote:
> Christopher Covington wrote:
 
> >+	if (!memcmp(table->header.oem_id, "QCOM  ", ACPI_OEM_ID_SIZE))
> >+		if (!memcmp(table->header.oem_table_id, "QDF2432 ",
> >+				ACPI_OEM_TABLE_ID_SIZE) ||
> >+				(!memcmp(table->header.oem_table_id,
> >+				"QDF2400 ", ACPI_OEM_TABLE_ID_SIZE) &&
> >+				table->header.oem_revision == 0))
> >+			uart = "qdf2400_e44";
> >+

Thanks for reworking this. I'm much happier with this than the MIDR
check.

Splitting out the test into its own function, as Timur suggested, would
generally be nicer. Minor comments on that below.

> static bool needs_qdf2400_e44(struct acpi_table_header *h)
> {

This is detecting the presence of the erratum so, has_qdf2400_e44() or
needs__qdf2400_e44_workaround() would be better names. I'd personally
prefer the former, but either is fine.

> 	const char *id;
> 
> 	/* The erratum only applies to Qualcomm Technologies SOCs */
> 	if (memcmp(h->oem_id, "QCOM  ", ACPI_OEM_ID_SIZE))
> 		return False;
> 
> 	id = h->oem_table_id;
> 
> 	if (!memcmp(id, "QDF2432 ", ACPI_OEM_TABLE_ID_SIZE))
> 		return True;
> 
> 	if (!memcmp(id, "QDF2000 ", ACPI_OEM_TABLE_ID_SIZE) &&
> 		h->oem_revision == 0)
> 		return True;
> 	
> 	return False;
> }

s/False/false/g
s/True/true/g

With that, this looks fine to me. I'm not too familiar with the pl011
driver. On the assumption the other changes have already been vetted:

Acked-by: Mark Rutland <mark.rutland@....com>

Thanks,
Mark.