linux-kernel - Re: [PATCH] sched/deadline: Remove unnecessary condition in push_dl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170215095547.4815596f@gandalf.local.home>
Date:   Wed, 15 Feb 2017 09:55:47 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Juri Lelli <juri.lelli@....com>
Cc:     Byungchul Park <byungchul.park@....com>, peterz@...radead.org,
        mingo@...nel.org, linux-kernel@...r.kernel.org,
        juri.lelli@...il.com, kernel-team@....com,
        Luca Abeni <luca.abeni@...tannapisa.it>
Subject: Re: [PATCH] sched/deadline: Remove unnecessary condition in
 push_dl_task()

On Wed, 15 Feb 2017 14:45:03 +0000
Juri Lelli <juri.lelli@....com> wrote:

> > 
> >   task = pick_next_pushable_dl_task(rq);
> > 
> > Which has:
> > 
> >   BUG_ON(rq->cpu != task_cpu(task))
> > 
> > when it returns a task other than NULL. Which means that task_cpu(task)
> > must be rq->cpu. Then if task == next_task, then task_cpu(next_task)
> > must be rq->cpu as well.  
> 
> Right.

Perhaps my comment should also be added in the change log.

-- Steve