linux-kernel - Re: [PATCH] of: add EXPORT_SYMBOL for of_device_compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 15 Feb 2017 07:34:57 -0800
From:   Frank Rowand <frowand.list@...il.com>
To:     Corentin Labbe <clabbe.montjoie@...il.com>, robh+dt@...nel.org
Cc:     devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] of: add EXPORT_SYMBOL for of_device_compatible_match

On 02/15/17 06:22, Corentin Labbe wrote:
> This symbol will be needed for the dwmac-sun8i ethernet driver.
> For letting it to be build as module, of_device_compatible_match need to
> be exported.
> 
> Signed-off-by: Corentin Labbe <clabbe.montjoie@...il.com>
> ---
>  drivers/of/base.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/of/base.c b/drivers/of/base.c
> index df6f6e3..fba351b 100644
> --- a/drivers/of/base.c
> +++ b/drivers/of/base.c
> @@ -524,6 +524,7 @@ int of_device_compatible_match(struct device_node *device,
>  
>  	return score;
>  }
> +EXPORT_SYMBOL(of_device_compatible_match);
>  
>  /**
>   * of_machine_is_compatible - Test root of device tree for a given compatible value
> 



Rob's reply to the last person who requested that:

   It's not missing because no modules use it. It's generally preferred
   to use a match table and of_match_node.

-Frank