linux-kernel - [PATCH] staging: visorbus, replace init_timer with setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 15 Feb 2017 17:04:26 +0100
From:   Jiri Slaby <jslaby@...e.cz>
To:     david.kershner@...sys.com
Cc:     linux-kernel@...r.kernel.org, Stefan Svinciak <xsvinc1@...muni.cz>,
        Jiri Slaby <jslaby@...e.cz>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        sparmaintainer@...sys.com, devel@...verdev.osuosl.org
Subject: [PATCH] staging: visorbus, replace init_timer with setup_timer

From: Stefan Svinciak <xsvinc1@...muni.cz>

Newer version is more readable and needs less changes if/when
timer_struct is to be changed.

Signed-off-by: Stefan Svinciak <xsvinc1@...muni.cz>
Signed-off-by: Jiri Slaby <jslaby@...e.cz>
Cc: David Kershner <david.kershner@...sys.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: <sparmaintainer@...sys.com>
Cc: <devel@...verdev.osuosl.org>
---
 drivers/staging/unisys/visorbus/visorbus_main.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c b/drivers/staging/unisys/visorbus/visorbus_main.c
index aea1aa262b28..55f29ae8e015 100644
--- a/drivers/staging/unisys/visorbus/visorbus_main.c
+++ b/drivers/staging/unisys/visorbus/visorbus_main.c
@@ -623,9 +623,7 @@ create_visor_device(struct visor_device *dev)
 	dev->device.release = visorbus_release_device;
 	/* keep a reference just for us (now 2) */
 	get_device(&dev->device);
-	init_timer(&dev->timer);
-	dev->timer.data = (unsigned long)(dev);
-	dev->timer.function = dev_periodic_work;
+	setup_timer(&dev->timer, dev_periodic_work, (unsigned long)dev);
 
 	/*
 	 * bus_id must be a unique name with respect to this bus TYPE
-- 
2.11.1