linux-kernel - Re: [PATCH] xfs: fix len comparison in xfs_extent_busy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 14 Feb 2017 18:17:34 -0800
From:   "Darrick J. Wong" <darrick.wong@...cle.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     linux-xfs@...r.kernel.org, Christoph Hellwig <hch@....de>,
        Dave Chinner <dchinner@...hat.com>,
        Brian Foster <bfoster@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] xfs: fix len comparison in xfs_extent_busy_trim

On Tue, Feb 14, 2017 at 06:08:30PM +0100, Arnd Bergmann wrote:
> The length is now passed by reference, so the assertion has to be updated
> to match the other changes, as pointed out by this W=1 warning:
> 
> fs/xfs/xfs_extent_busy.c: In function 'xfs_extent_busy_trim':
> fs/xfs/xfs_extent_busy.c:356:13: error: ordered comparison of pointer with integer zero [-Werror=extra]
> 
> Fixes: ebf55872616c ("xfs: improve handling of busy extents in the low-level allocator")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Thanks, applied (4.11).

--D

> ---
>  fs/xfs/xfs_extent_busy.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_extent_busy.c b/fs/xfs/xfs_extent_busy.c
> index ab062610234e..77760dbf0242 100644
> --- a/fs/xfs/xfs_extent_busy.c
> +++ b/fs/xfs/xfs_extent_busy.c
> @@ -353,7 +353,7 @@ xfs_extent_busy_trim(
>  	struct rb_node		*rbp;
>  	bool			ret = false;
>  
> -	ASSERT(len > 0);
> +	ASSERT(*len > 0);
>  
>  	spin_lock(&args->pag->pagb_lock);
>  restart:
> -- 
> 2.9.0
>