linux-kernel - Re: [PATCH v2 0/4] PTP attribute handling cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170215.122215.823469813998299884.davem@davemloft.net>
Date:   Wed, 15 Feb 2017 12:22:15 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     dmitry.torokhov@...il.com
Cc:     richardcochran@...il.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/4] PTP attribute handling cleanup

From: Dmitry Torokhov <dmitry.torokhov@...il.com>
Date: Tue, 14 Feb 2017 10:23:30 -0800

> PTP core was creating some attributes, such as "period" and "fifo", and the
> entire "pins" attribute group, after creating class deevice, which creates
> a race for userspace: uevent may arrive before all attributes are created.
> 
> This series of patches switches PTP to use is_visible() to control
> visibility of attributes in a group, and device_create_with_groups() to
> ensure that attributes are created before we notify userspace of a new
> device.

Richard, please review.