linux-kernel - Re: [PATCH] staging: rtl8192u: Fix warnings about endianness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170215203115.GC4108@mwanda>
Date:   Wed, 15 Feb 2017 23:31:16 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     maomao xu <albert008.xu@...il.com>, devel@...verdev.osuosl.org,
        gregkh <gregkh@...uxfoundation.org>,
        Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Rashika Kheria <rashika.kheria@...il.com>,
        singhalsimran0@...il.com
Subject: Re: [PATCH] staging: rtl8192u: Fix warnings about endianness

On Wed, Feb 15, 2017 at 09:33:15AM +0100, Arnd Bergmann wrote:
> I see the same warning was addressed very differently in 99277c1f9962
> ("Staging: rtl8192e: Fix Sparse warning of cast to restricted __le16 in
>  rtllib_crypt_tkip.c"), which was for a close relative of that driver.
> 
> Only one of the two approaches (at most) can be correct, so we
> regardless of your patch either rtl8192e or rtl8192u is broken on
> big-endian machines.

99277c1f9962 ("Staging: rtl8192e: Fix Sparse warning of cast to restricted __le16 in
rtllib_crypt_tkip.c") is obviously broken.  Can you send a patch to
change it back?

regards,
dan carpenter