linux-kernel - Re: [RFC] blkio_delay_total is calculated mistakenly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 14 Feb 2017 22:12:24 -0500
From:   Weiwei Jia <harrynjit@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     bsingharora@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [RFC] blkio_delay_total is calculated mistakenly

On Tue, Feb 14, 2017 at 10:00 PM, Greg KH <gregkh@...uxfoundation.org> wrote:
> On Tue, Feb 14, 2017 at 08:27:36PM -0500, Weiwei Jia wrote:
>> Hi,
>>Balbir Singh <bsingharora@...il.com>
>> When I read Linux Kernel source codes about how "blkio_delay_total"
>> (delay waiting for synchronous block I/O to complete for one task) is
>> calculated in Linux/kernel/delayacct.c file [1], I find that
>> "blkio_delay_total" adds "task->delays->blkio_delay" to be the total
>> delay time for one task to wait for synchronous I/O dynamically but
>> "tsk->delays->blkio_delay" has already been calculated as the total
>> delay time that one task is waiting for synchronous I/O [2]
>> dynamically. I think "blkio_delay_total" should not add
>> "task->delays->blkio_delay" since "task->delays->blkio_delay" is
>> already the total delay time we want.
>>
>> Am I missing anything?
>
> Why are you sending this to me?  You have read
> Documentation/SubmittingPatches, right?
>
> Please use scripts/get_maintainers.pl for who to send patches to.

Okay. Have cc'ed Balbir Singh <bsingharora@...il.com> already.

Thanks,
Weiwei Jia