linux-kernel - Re: [PATCH] net: ethernet: cadence: Add fixed-link functionality

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170215221249.GB6096@lunn.ch>
Date:   Wed, 15 Feb 2017 23:12:49 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     mdf@...nel.org
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        moritz.fischer@...us.com,
        Nicolas Ferre <nicolas.ferre@...rochip.com>
Subject: Re: [PATCH] net: ethernet: cadence: Add fixed-link functionality

> @@ -3342,8 +3371,18 @@ static int macb_probe(struct platform_device *pdev)
>  		macb_get_hwaddr(bp);
>  
>  	/* Power up the PHY if there is a GPIO reset */
> -	phy_node =  of_get_next_available_child(np, NULL);
> -	if (phy_node) {
> +	phy_node = of_parse_phandle(np, "phy-handle", 0);
> +	if (!phy_node && of_phy_is_fixed_link(np)) {
> +		err = of_phy_register_fixed_link(np);

Hi Moritz

I don't see any calls to of_phy_deregister_fixed_link(), either in the
error path, or the remove code.

      Andrew