linux-kernel - [PATCH 3.16 038/306] pstore/ram: Use memcpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <lsq.1487198500.154090150@decadent.org.uk>
Date:   Wed, 15 Feb 2017 22:41:40 +0000
From:   Ben Hutchings <ben@...adent.org.uk>
To:     linux-kernel@...r.kernel.org, stable@...r.kernel.org
CC:     akpm@...ux-foundation.org, "Olof Johansson" <olofj@...omium.org>,
        "Kees Cook" <keescook@...omium.org>,
        "Furquan Shaikh" <furquan@...gle.com>,
        "Furquan Shaikh" <furquan@...omium.org>,
        "Aaron Durbin" <adurbin@...omium.org>,
        "Enric Balletbo Serra" <enric.balletbo@...labora.com>
Subject: [PATCH 3.16 038/306] pstore/ram: Use memcpy_toio instead of memcpy

3.16.40-rc1 review patch.  If anyone has any objections, please let me know.

------------------

From: Furquan Shaikh <furquan@...gle.com>

commit 7e75678d23167c2527e655658a8ef36a36c8b4d9 upstream.

persistent_ram_update uses vmap / iomap based on whether the buffer is in
memory region or reserved region. However, both map it as non-cacheable
memory. For armv8 specifically, non-cacheable mapping requests use a
memory type that has to be accessed aligned to the request size. memcpy()
doesn't guarantee that.

Signed-off-by: Furquan Shaikh <furquan@...gle.com>
Signed-off-by: Enric Balletbo Serra <enric.balletbo@...labora.com>
Reviewed-by: Aaron Durbin <adurbin@...omium.org>
Reviewed-by: Olof Johansson <olofj@...omium.org>
Tested-by: Furquan Shaikh <furquan@...omium.org>
Signed-off-by: Kees Cook <keescook@...omium.org>
Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
---
 fs/pstore/ram_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/fs/pstore/ram_core.c
+++ b/fs/pstore/ram_core.c
@@ -263,7 +263,7 @@ static void notrace persistent_ram_updat
 	const void *s, unsigned int start, unsigned int count)
 {
 	struct persistent_ram_buffer *buffer = prz->buffer;
-	memcpy(buffer->data + start, s, count);
+	memcpy_toio(buffer->data + start, s, count);
 	persistent_ram_update_ecc(prz, start, count);
 }