linux-kernel - Re: [PATCH] sched/deadline: Remove unnecessary condition in push_dl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170216024104.GT16086@X58A-UD3R>
Date:   Thu, 16 Feb 2017 11:41:04 +0900
From:   Byungchul Park <byungchul.park@....com>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Juri Lelli <juri.lelli@....com>, peterz@...radead.org,
        mingo@...nel.org, linux-kernel@...r.kernel.org,
        juri.lelli@...il.com, kernel-team@....com,
        Luca Abeni <luca.abeni@...tannapisa.it>
Subject: Re: [PATCH] sched/deadline: Remove unnecessary condition in
 push_dl_task()

On Wed, Feb 15, 2017 at 09:33:35PM -0500, Steven Rostedt wrote:
> On Wed, 15 Feb 2017 21:31:50 -0500
> Steven Rostedt <rostedt@...dmis.org> wrote:
> 
> > On Thu, 16 Feb 2017 11:17:58 +0900
> > Byungchul Park <byungchul.park@....com> wrote:
> > 
> > 
> > > Juri and steven, thank you very much for reviewing it.
> > > 
> > > I'm not sure and familiar with... Should I add your 'reviewed by' into
> > > my patches by myself?
> > >   
> > 
> > No, it's the maintainer's job to add these tags when they take your
> > patch. If you were to resend the patch because of a minor change
> > (something a reviewer told you to make but still gave you their
> > reviewed-by tag), then you could add it. Or if you have a patch series
> > and resend a new series, you can add the reviewed-by tags to the
> > patches that were not changed. But if you were to change a patch, then
> > you need to ask the reviewer to give their tag again, because they need
> > to review the changes made before their tag should go on it.
> > 
> 
> I just noticed that you sent a v2 of the patch we reviewed. Since you
> didn't change it, you could have added our review-by tags. That makes
> it a bit easier for maintainers to know.

I got it! Thank you very much for your kind explanation.

> 
> -- Steve