linux-kernel - [PATCH] async_tx: deprecate broken support for channel switching

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <148721292971.19343.10618932473668163270.stgit@dwillia2-desk3.amr.corp.intel.com>
Date:   Wed, 15 Feb 2017 18:42:09 -0800
From:   Dan Williams <dan.j.williams@...el.com>
To:     vinod.koul@...el.com
Cc:     Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>,
        Anup Patel <anup.patel@...adcom.com>,
        Rameshwar Prasad Sahu <rsahu@....com>,
        Russell King <linux@...linux.org.uk>,
        linux-kernel@...r.kernel.org, linux-raid@...r.kernel.org,
        dmaengine@...r.kernel.org, Anatolij Gustschin <agust@...x.de>,
        Saeed Bishara <saeed.bishara@...il.com>
Subject: [PATCH] async_tx: deprecate broken support for channel switching

Back in 2011, Russell pointed out that the "async_tx channel switch"
capability was violating expectations of the dma mapping api [1]. At the
time the existing uses were reviewed as still usable, but that longer
term we needed a rework of the raid offload implementation. While some
of the framework for a fixed implementation was introduced in 2012 [2],
the wider rewrite never materialized.

There continues to be interest in raid offload with new dma/raid engine
drivers being submitted. Those drivers must not build on top of the
broken channel switching capability.

Prevent async_tx from using an offload engine if the channel switching
capability is enabled. This still allows the engine to be used for other
purposes, but the broken way async_tx uses these engines for raid will
be disabled. For configurations where this causes a performance
regression the only solution is to start the work of eliminating the
async_tx api and moving channel management into the raid code directly
where it can manage marshalling an operation stream between multiple dma
channels.

[1]: http://lists.infradead.org/pipermail/linux-arm-kernel/2011-January/036753.html
[2]: https://lkml.org/lkml/2012/12/6/71

Cc: Anatolij Gustschin <agust@...x.de>
Cc: Anup Patel <anup.patel@...adcom.com>
Cc: Rameshwar Prasad Sahu <rsahu@....com>
Cc: Saeed Bishara <saeed.bishara@...il.com>
Cc: Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
Reported-by: Russell King <linux@...linux.org.uk>
Signed-off-by: Dan Williams <dan.j.williams@...el.com>
---
 include/linux/async_tx.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/async_tx.h b/include/linux/async_tx.h
index 388574ea38ed..28e3cf1465ab 100644
--- a/include/linux/async_tx.h
+++ b/include/linux/async_tx.h
@@ -87,7 +87,7 @@ struct async_submit_ctl {
 	void *scribble;
 };

-#ifdef CONFIG_DMA_ENGINE
+#if defined(CONFIG_DMA_ENGINE) && !defined(CONFIG_ASYNC_TX_CHANNEL_SWITCH)
 #define async_tx_issue_pending_all dma_issue_pending_all

 /**