linux-kernel - Re: [PATCH v2 0/6] Move dell-led to drivers/platform/x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170216093311.GB1350@ozzy.nask.waw.pl>
Date:   Thu, 16 Feb 2017 10:33:11 +0100
From:   Michał Kępień <kernel@...pniu.pl>
To:     Pali Rohár <pali.rohar@...il.com>
Cc:     Alex Hung <alex.hung@...onical.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Anthony Wong <anthony.wong@...onical.com>,
        Richard Purdie <rpurdie@...ys.net>,
        Jacek Anaszewski <jacek.anaszewski@...il.com>,
        Pavel Machek <pavel@....cz>,
        Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Linux LED Subsystem <linux-leds@...r.kernel.org>,
        "platform-driver-x86@...r.kernel.org" 
        <platform-driver-x86@...r.kernel.org>, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/6] Move dell-led to drivers/platform/x86

> > >> 6. Compiled and installed Linux kernel 4.10 rc8
> > >>
> > >>   -> Microphone mute led does not work
> > >
> > > This is even more confusing.  Between 4.9, which you claim works fine,
> > > and 4.10-rc8, which you claim does not work, I can see no changes to
> > > either drivers/leds/dell-led.c or sound/pci/hda/dell_wmi_helper.c.
> > > Kernel configuration issue?
> > 
> > I was surprised too, and I compiled it twice and installed on both
> > Ubuntu 16.04 and 16.10.
> > 
> > I would guess it is config too. On 4.9, it was using Ubuntu default.
> > On 4.10rc8, I am pretty much using the instruction on
> > https://wiki.ubuntu.com/KernelTeam/GitKernelBuild. The .config is
> > available @ http://paste.ubuntu.com/24001113/
> 
> In Patch 6/6 is: Kconfig option is renamed from
> CONFIG_LEDS_DELL_NETBOOKS to CONFIG_DELL_WMI_LED.
> So you need to update your config for testing.

I also thought about this, but CONFIG_DELL_WMI_LED is only needed to
support the Dell Activity LED (present in the Dell Latitude 2100
netbook).  Meanwhile, Alex is only testing the microphone mute LED,
which requires CONFIG_DELL_LAPTOP to be enabled.  The cover letter for
this patch series provides a more thorough explanation.

-- 
Best regards,
Michał Kępień