lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 16 Feb 2017 14:31:38 +0100 From: Arnd Bergmann <arnd@...db.de> To: linux-arm-kernel@...ts.infradead.org Cc: Chunyan Zhang <chunyan.zhang@...eadtrum.com>, robh+dt@...nel.org, mark.rutland@....com, gregkh@...uxfoundation.org, catalin.marinas@....com, will.deacon@....com, orson.zhai@...eadtrum.com, linux-kernel@...r.kernel.org, devicetree@...r.kernel.org Subject: Re: [PATCH 4/5] sprd_serial: switch comptible string to sc-uart On Tuesday, February 14, 2017 5:19:11 PM CET Chunyan Zhang wrote: > static const struct of_device_id serial_ids[] = { > - {.compatible = "sprd,sc9836-uart",}, > + {.compatible = "sprd,sc-uart",}, > {} We really need this to be specific, in case Spreadtrum ever makes a slightly different UART that is not 100% compatible with this one. Also, you can't remove the string you already have, only add to it. Normally when you have a new chip that is compatible with one we already have a driver for, we mark the device as compatible with the old one and avoid having to change the driver, e.g. compatible = "sprd,sc9995-uart", "sprd,sc9836-uart"; This way, the driver could later be changed to handle anything that is compatible with sc9995 differently from sc9836, but by default it would match the original string. Arnd
Powered by blists - more mailing lists