linux-kernel - Re: [PATCH v2] btrfs: remove btrfs_err_str function from uapi/linux/btrfs.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170216141540.GS16928@suse.cz>
Date:   Thu, 16 Feb 2017 15:15:40 +0100
From:   David Sterba <dsterba@...e.cz>
To:     "Dmitry V. Levin" <ldv@...linux.org>
Cc:     Jeff Mahoney <jeffm@...e.com>, Josef Bacik <jbacik@...com>,
        Anand Jain <anand.jain@...cle.com>,
        Liu Bo <bo.li.liu@...cle.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] btrfs: remove btrfs_err_str function from
 uapi/linux/btrfs.h

On Thu, Feb 16, 2017 at 01:55:03AM +0300, Dmitry V. Levin wrote:
> btrfs_err_str function is not called from anywhere and is replicated
> in the userspace headers for btrfs-progs.
> 
> It's removal also fixes the following linux/btrfs.h userspace
> compilation error:
> 
> /usr/include/linux/btrfs.h: In function 'btrfs_err_str':
> /usr/include/linux/btrfs.h:740:11: error: 'NULL' undeclared (first use in this function)
>     return NULL;
> 
> Suggested-by: Jeff Mahoney <jeffm@...e.com>
> Signed-off-by: Dmitry V. Levin <ldv@...linux.org>

Reviewed-by: David Sterba <dsterba@...e.com>