linux-kernel - Re: [PATCH] drm/amdgpu: fix warning on older gcc releases

Open Source and information security mailing list archives

Date:   Thu, 16 Feb 2017 12:21:07 -0500
From:   Alex Deucher <alexdeucher@...il.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Alex Deucher <alexander.deucher@....com>,
        Tom St Denis <tom.stdenis@....com>,
        LKML <linux-kernel@...r.kernel.org>,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>, Rex Zhu <Rex.Zhu@....com>,
        Christian König <christian.koenig@....com>,
        Monk Liu <Monk.Liu@....com>
Subject: Re: [PATCH] drm/amdgpu: fix warning on older gcc releases

On Fri, Feb 3, 2017 at 11:47 AM, Arnd Bergmann <arnd@...db.de> wrote:
> gcc-4.8 warns about '{0}' being used an an initializer for nested structures:
>
> drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c: In function ‘gfx_v8_0_ring_emit_ce_meta_init’:
> drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c:7263:2: warning: missing braces around initializer [-Wmissing-braces]
>   } ce_payload = {0};
> drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c: In function ‘gfx_v8_0_ring_emit_de_meta_init’:
> drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c:7290:2: warning: missing braces around initializer [-Wmissing-braces]
>   } de_payload = {0};
>
> Using an empty {} initializer however has the same effect and works on all versions.
>
> Fixes: acad2b2a7b70 ("drm/amdgpu:implement CE/DE meta-init routines")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied.  thanks!

Alex

> ---
>  drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
> index 35f9cd83b821..cf1cb406b5ed 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
> @@ -7260,7 +7260,7 @@ static void gfx_v8_0_ring_emit_ce_meta_init(struct amdgpu_ring *ring, uint64_t c
>         static union {
>                 struct amdgpu_ce_ib_state regular;
>                 struct amdgpu_ce_ib_state_chained_ib chained;
> -       } ce_payload = {0};
> +       } ce_payload = {};
>
>         if (ring->adev->virt.chained_ib_support) {
>                 ce_payload_addr = csa_addr + offsetof(struct amdgpu_gfx_meta_data_chained_ib, ce_payload);
> @@ -7287,7 +7287,7 @@ static void gfx_v8_0_ring_emit_de_meta_init(struct amdgpu_ring *ring, uint64_t c
>         static union {
>                 struct amdgpu_de_ib_state regular;
>                 struct amdgpu_de_ib_state_chained_ib chained;
> -       } de_payload = {0};
> +       } de_payload = {};
>
>         gds_addr = csa_addr + 4096;
>         if (ring->adev->virt.chained_ib_support) {
> --
> 2.9.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives